Unit 9: footer, about page, and analytics dispatcher refactor#11
Open
stradichenko wants to merge 1 commit intomainfrom
Open
Unit 9: footer, about page, and analytics dispatcher refactor#11stradichenko wants to merge 1 commit intomainfrom
stradichenko wants to merge 1 commit intomainfrom
Conversation
- analytics.html: replace 5 unconditional sub-partial calls with a single provider dispatcher driven by site.Params.analytics.provider, wrapped in partialCached. Provider sub-partials are also cached, keyed on provider name. - footer.html: stop loading footer.css here (Unit 6 bundles it via head/styles.html). Lowercase site.Params throughout. Replace now.Year with time.Now.Year. Add aria-hidden + focusable=false to inline social SVGs. Render customText as plain text by default; opt in to safeHTML via site.Params.footer.allowHTML = true. - about.html: lowercase site.Params; i18n NoSocialLinks / NoInterests / Interests with English fallback via | default. Add a TODO marker for Unit 12 (zipfs-law CSS will move into the widget refactor). - about-profile.css: append the .about-section h1 rule that was inline in about.html, keeping the same selector so the page renders identically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
analytics.html: replace 5 unconditional sub-partial calls with a single provider dispatcher driven bysite.Params.analytics.provider, wrapped inpartialCached. Provider sub-partials are also cached, keyed on provider name.footer.html: stop loadingfooter.csshere (Unit 6 bundles it viahead/styles.html). Lowercasesite.Paramsthroughout. Replacenow.Yearwithtime.Now.Year. Addaria-hidden+focusable="false"to inline social SVGs. RendercustomTextas plain text by default; opt in tosafeHTMLviasite.Params.footer.allowHTML = true.about.html: lowercasesite.Params; i18nNoSocialLinks/NoInterests/Interestswith English fallback via| default. Add a TODO marker for Unit 12 (zipfs-law CSS will move into the widget refactor).about-profile.css: append the.about-section h1rule that was inline inabout.html.Test plan
footer.csslink (Unit 6 owns the bundle).<style>.site.Params.analytics.provider = "plausible", only the plausible partial is rendered.Part of the PKB-theme modernization batch (15 units).